Had a conversation with my intern this morning about style comments in code reviews. My tl;dr: code style comments are tiny cuts to someone's confidence and you should weigh that vs the value of the "fixing" it.
31
102
624
He brought it up because he noticed a stark contrast between what I comment on and what some others comment on My 2c is that death by 1000 cuts is never worth it for style comments, and they're usually a waste of everyone's time Automate format/linting. You owe it to each other
9
54
394
Tools like linters, stuff like cargo clippy, things like auto-formatters should be considered essential these days, not nice to haves. And they should be as un-configurable as possible (I'm giving eslint a hard side-eye here). Normalize automated, language-wide standards
15
26
290
But in all seriousness, I have much better things to do as a senior engineer than require folks to fix how much space is between an if and its opening paren. It's ok to do the occasional thing AND MARK IT AS A NIT:, but if a lot of your review is this? You're wasting time.
14
13
228
Replying to @zkat__

3:21 PM · Aug 27, 2020

0
0
0
GIF